Add support for query RBAC to tempomonolithic #1131
Conversation
pavolloffay
force-pushed
the
rbac-monolithic
branch
from
582f44c to
21a6a1d
Compare
| // | ||
| // +kubebuilder:validation:Optional | ||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Query Configuration",xDescriptors="urn:alm:descriptor:com.tectonic.ui:advanced" | ||
| Query MonolithicQuerySpec `json:"query,omitempty"` |
There was a problem hiding this comment.
| Query MonolithicQuerySpec `json:"query,omitempty"` | |
| Query *MonolithicQuerySpec `json:"query,omitempty"` |
In the monolithic CR we use pointers for all structs, because otherwise, writing an empty spec to the cluster and reading it back gives two different YAML objects, like this:
spec:
query:
rbac: {}
In the tempomonolithic_defaults.go we fill in the possibly-nil pointers to avoid panics when reading from nil pointers:
tempo-operator/api/tempo/v1alpha1/tempomonolithic_defaults.go
Lines 48 to 53 in 7846041
| // +optional | ||
| // +kubebuilder:validation:Optional | ||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Query RBAC Settings" | ||
| RBAC RBACSpec `json:"rbac,omitempty"` |
There was a problem hiding this comment.
| RBAC RBACSpec `json:"rbac,omitempty"` | |
| RBAC *RBACSpec `json:"rbac,omitempty"` |
same as above
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
rbac-monolithic
branch
from
21a6a1d to
5a89394
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
- Coverage 58.58% 58.56% -0.02%
==========================================
Files 113 113
Lines 10213 10246 +33
==========================================
+ Hits 5983 6001 +18
- Misses 3922 3937 +15
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pavol Loffay <[email protected]>
https://issues.redhat.com/browse/TRACING-5134